apeforest commented on a change in pull request #15593: Large Index Support for 
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r311693093
 
 

 ##########
 File path: include/mxnet/c_api.h
 ##########
 @@ -565,6 +567,13 @@ MXNET_DLL int MXNDArrayCreateEx(const mx_uint *shape,
                               int dtype,
                               NDArrayHandle *out);
 
+MXNET_DLL int MXNDArrayCreateExInt64(const mx_int64 *shape,
 
 Review comment:
   I guess since the original API does not have suffix 'INT', maybe using 
suffix '64' makes sense as @larroy suggested. I don't have strong preference. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to