samskalicky commented on a change in pull request #15921: [WIP] dynamic custom
operator support
URL: https://github.com/apache/incubator-mxnet/pull/15921#discussion_r317714848
##########
File path: Makefile
##########
@@ -660,7 +660,7 @@ pylint:
python3 -m pylint --rcfile=$(ROOTDIR)/ci/other/pylintrc
--ignore-patterns=".*\.so$$,.*\.dll$$,.*\.dylib$$" python/mxnet
tools/caffe_converter/*.py
sample_lib:
- $(CXX) -shared -fPIC -std=c++11 example/lib_api/mylib.cc -o
libsample_lib.so -I include/mxnet
+ $(CXX) -shared -fPIC -std=c++11 example/lib_ops/mylib.cc -o
libsample_lib.so -I include/mxnet
Review comment:
I guess this checks the same things that were tested by the previous library
loading unit test. But if we change this here, we should also change it in the
CMakeLists.txt too. We'll probably want to update the test in unittests
test_library_loading.py to try and do something with the operator in the
library to enhance the test in the CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
