samskalicky commented on a change in pull request #15921: [WIP] dynamic custom operator support URL: https://github.com/apache/incubator-mxnet/pull/15921#discussion_r318934388
########## File path: example/lib_ops/mylib.cc ########## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * Copyright (c) 2015 by Contributors + * \file mylib.cc + * \brief Sample library file + */ + +#include <iostream> +#include "lib_api.h" + +/* + * main matrix multiplication routine + */ +void gemm(float* A, float* B, float* C, unsigned n, unsigned k, unsigned m) { + unsigned i,j,kk; + for (i=0;i<n;i++) { + for (j=0;j<m;j++) { + C[i*m+j] = 0; + for (kk=0;kk<k;kk++) { + C[i*m+j] += A[i*k+kk] * B[kk*m+j]; + } + } + } +} + + +int myFCompute(std::map<std::string,std::string> attrs, + std::vector<MXTensor> inputs, std::vector<MXTensor> outputs) { + //validate inputs + for(int i=0; i<inputs.size(); i++) { + if(inputs[i].dtype != kFloat32) { + std::cout << "Expected input " << i << " to have float32 type" << std::endl; + return 0; + } + } + + //extract data pointers from tensors + float* input1 = inputs[0].getData<float>(); + float* input2 = inputs[1].getData<float>(); + float* output = outputs[0].getData<float>(); + //set tensor shapes + unsigned n = inputs[0].shape[0]; + unsigned k = inputs[0].shape[1]; + unsigned m = inputs[1].shape[1]; + + gemm(input1, input2, output, n, k, m); + + return 1; //no error +} + +int parseAttrs(std::map<std::string,std::string> attrs, + int* num_in, int* num_out) { + /* + if(attrs.find("myParam") == attrs.end()) { + std::cout << "Missing param 'myParam'" << std::endl; + return 0; + } + */ + *num_in = 2; + *num_out = 1; + + return 1; //no error +} + +int inferType(std::map<std::string,std::string> attrs, std::vector<int> &intypes, + std::vector<int> &outtypes) { + outtypes[0] = intypes[0]; + + return 1; //no error +} + +int inferShape(std::map<std::string,std::string> attrs, std::vector<std::vector<unsigned int>> &inshapes, + std::vector<std::vector<unsigned int>> &outshapes) { + //validate inputs + if(inshapes.size() != 2) { + std::cout << "Expected 2 inputs to inferShape" << std::endl; + return 0; + } + + if(inshapes[0].size() != 2) { + std::cout << "Expected 2D for first input to inferShape" << std::endl; + return 0; + } + + if(inshapes[1].size() != 2) { + std::cout << "Expected 2D for second input to inferShape" << std::endl; + return 0; + } + + unsigned n = inshapes[0][0]; + unsigned k = inshapes[0][1]; + unsigned kk = inshapes[1][0]; + unsigned m = inshapes[1][1]; + + std::cout << "inshapes[0][0]=" << n << " inshapes[0][1]=" << k << std::endl; + std::cout << "inshapes[1][0]=" << kk << " inshapes[1][1]=" << m << std::endl; + + if(k != kk) return 0; + + outshapes[0].push_back(n); + outshapes[0].push_back(m); + + return 1; //no error +} + +REGISTER_OP(sam) +.setFCompute(myFCompute) +.setParseAttrs(parseAttrs) +.setInferType(inferType) +.setInferShape(inferShape); + +int initialize(int version) { Review comment: Im not sure I agree with making the version number a struct. I have seen other projects use the same version formatting before where its like: major*10000 + minor*100 + patch. And since its easy and we comment in the APIs I dont think this is a user impediment/confusion. But I do like the idea of versioning the the structures in lib_api.h that way we can validate if the user has an old library in a new version of MXNet with new APIs. I added this enhancement. Good idea! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
