ZhennanQin commented on a change in pull request #16141: [mkldnn-v1.0] Add
MKL-DNN Convolution
URL: https://github.com/apache/incubator-mxnet/pull/16141#discussion_r324520273
##########
File path: src/common/exec_utils.h
##########
@@ -59,15 +59,15 @@ inline bool SetupDefaultBlobsIn(const
std::vector<NDArray>& src,
for (size_t i = 0; i < src.size(); i++) {
auto& nd = src[i];
bool is_default = nd.storage_type() == kDefaultStorage;
-#if MXNET_USE_MKLDNN == 1
+#if MXNET_USE_MKLDNN == 100
Review comment:
If we upgrade mkldnn to version 1.1, shall we have to change this to
something like 110? I prefer not encoding the version into this macro.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
