ZhennanQin commented on a change in pull request #16141: [mkldnn-v1.0] Add
MKL-DNN Convolution
URL: https://github.com/apache/incubator-mxnet/pull/16141#discussion_r325458549
##########
File path: src/operator/nn/convolution.cc
##########
@@ -60,8 +60,12 @@ static void ConvolutionComputeExCPU(const nnvm::NodeAttrs&
attrs,
const ConvolutionParam& params = nnvm::get<ConvolutionParam>(attrs.parsed);
if (SupportMKLDNNConv(params, inputs[0])) {
MKLDNN_OPCHECK_INIT(false, outputs.size(), inputs, outputs);
- const auto mkldnn_inputs = GetMKLDNNInputArray(inputs);
- MKLDNNConvolutionForward(attrs, ctx, mkldnn_inputs, req, outputs);
+ if (CheckMKLDNNInputArrayIsView(inputs)) {
Review comment:
Make line 63 - 67 into a helper function, like
```
MKLDNNRun(MKLDNNConvolutionForward, attrs, ctx, inputs, req, outputs);
```
Then we can use this for all operators.
macro also works here, just like `MKLDNN_OPCHECK_RUN`. Depends on your
preference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
