apeforest commented on a change in pull request #16218: Improving performance 
of argmax operator
URL: https://github.com/apache/incubator-mxnet/pull/16218#discussion_r328383182
 
 

 ##########
 File path: tests/python/unittest/test_operator.py
 ##########
 @@ -7535,6 +7535,15 @@ def test_softmax():
     check_smoothed_softmax_grad(default_context())
 
 
+def create_data(batch_size, num_labels, ctx=None, dtype=None, H=None, W=None):
 
 Review comment:
   Maybe you could reuse this test util 
https://github.com/apache/incubator-mxnet/blob/df34e768ed5d4dd334c0dce7ce42384d7b62ee8f/python/mxnet/test_utils.py#L92?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to