apeforest commented on a change in pull request #16218: Improving performance
of argmax operator
URL: https://github.com/apache/incubator-mxnet/pull/16218#discussion_r328384295
##########
File path: tests/python/unittest/test_operator.py
##########
@@ -7604,6 +7612,161 @@ def _softmaxoutput_normalization(multi_output,
use_ignore, normalization):
multi_output, use_ignore, normalization)
+@with_seed()
+def test_argmax():
+ ci_test = True # Use False if you need to collect aggregated
information about argmax performance
Review comment:
Thanks for adding the script for performance test. But I feel this is
probably not the best place to add performance test in unit test. Maybe can you
separate the performance test logic and add it to
https://github.com/apache/incubator-mxnet/blob/master/tests/nightly/test_large_array.py?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
