utzig commented on a change in pull request #140: newt - Repo dependencies
URL: https://github.com/apache/mynewt-newt/pull/140#discussion_r172847193
 
 

 ##########
 File path: newt/downloader/downloader.go
 ##########
 @@ -667,8 +667,8 @@ func (ld *LocalDownloader) CurrentBranch(path string) 
(string, error) {
 }
 
 func (ld *LocalDownloader) UpdateRepo(path string, branchName string) error {
-       // Nothing to update in a local repo.
-       return nil
+       os.RemoveAll(path)
 
 Review comment:
   Hmmm, if I understand this correctly, it would be completely removing the 
local path including any changes that the user might have made, is that ok?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to