sjanc commented on a change in pull request #882: libc: Add support for float 
in printf
URL: https://github.com/apache/mynewt-core/pull/882#discussion_r172848803
 
 

 ##########
 File path: libc/baselibc/src/tinyprintf.c
 ##########
 @@ -337,6 +342,50 @@ size_t tfp_format(FILE *putp, const char *fmt, va_list va)
                 written += putchw(putp, &p);
                 p.bf = bf;
                 break;
+            case 'f':
+                p.base = 10;
+                volatile number_t num;
+                int n;
+                /* Check that the va pointer is 8 byte aligned,
+                 * and increment it if it is not */
+                if((int)va.__ap % 8)
 
 Review comment:
   space after if and braces

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to