sjanc commented on a change in pull request #882: libc: Add support for float in printf URL: https://github.com/apache/mynewt-core/pull/882#discussion_r172842782
########## File path: libc/baselibc/src/tinyprintf.c ########## @@ -337,6 +342,50 @@ size_t tfp_format(FILE *putp, const char *fmt, va_list va) written += putchw(putp, &p); p.bf = bf; break; + case 'f': + p.base = 10; + volatile number_t num; Review comment: why volatile? and declare variable at function begining ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services