sterlinghughes commented on issue #889: implementation of common button events URL: https://github.com/apache/mynewt-core/pull/889#issuecomment-371585285 Stephane -- thank you for this pull request, it looks like a great addition. I have a number of comments regarding coding standards and documentation, but generally I'd love to have it as a part of Mynewt. As a small nit, are you OK with renaming it "button" versus "btn" -- I think button is not _that_ many more characters and reads nicer. I'll make more comments inline.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
