sterlinghughes commented on issue #889: implementation of common button events URL: https://github.com/apache/mynewt-core/pull/889#issuecomment-375354183 Hi Stephane, there were a bunch of coding style comments I originally made. I'd really like to merge this PR, so I can either merge & then fix coding style and then re-push -- or it would be great if you could make the changes. Let me know if you'd be willing to do this, we'd love to get you submitting lots of PRs to Mynewt :-) The major ones are: - declaring function brace on a new line i.e. int bla(void) { and not int bla(void) { - Variables should only be assigned constants on declaration at the top of a function: i.e. int bla(int *c) { int b; b = *c; } and not: int bla(int *c) { int b = *c; } But OK is: int bla(int *c) { int a = 10;
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
