mlaz commented on a change in pull request #1102: Feature/stm32 pwm enabled URL: https://github.com/apache/mynewt-core/pull/1102#discussion_r188964866
########## File path: hw/bsp/nucleo-f303re/src/hal_bsp.c ########## @@ -80,7 +80,50 @@ bsp_uart_config(int port) assert(port < UART_CNT); return &uart_cfg[port]; } + +static char *stm32_uart_dev_name[UART_CNT] = { +#if UART_CNT > 0 + "uart0", +#endif +#if UART_CNT > 1 + "uart1", +#endif +}; + +#endif + + +#if PWM_CNT +#include <pwm_stm32/pwm_stm32.h> +static struct pwm_dev stm32_pwm_dev_driver[PWM_CNT]; +static const char *stm32_pwm_dev_name[PWM_CNT] = { +#if PWM_CNT > 0 + "pwm0", #endif +#if PWM_CNT > 1 + "pwm1", +#endif +#if PWM_CNT > 2 + "pwm2", +#endif +}; + +static struct stm32_pwm_conf stm32_pwm_config[PWM_CNT] = { +#if MYNEWT_VAL(PWM_0) + { TIM2, TIM2_IRQn }, Review comment: Here, the same as above. What if you only enable PWM_0 ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services