mlaz commented on a change in pull request #1102: Feature/stm32 pwm enabled
URL: https://github.com/apache/mynewt-core/pull/1102#discussion_r188964597
##########
File path: hw/bsp/nucleo-f303re/src/hal_bsp.c
##########
@@ -80,7 +80,50 @@ bsp_uart_config(int port)
assert(port < UART_CNT);
return &uart_cfg[port];
}
+
+static char *stm32_uart_dev_name[UART_CNT] = {
+#if UART_CNT > 0
+ "uart0",
+#endif
+#if UART_CNT > 1
+ "uart1",
+#endif
+};
+
+#endif
+
+
+#if PWM_CNT
+#include <pwm_stm32/pwm_stm32.h>
+static struct pwm_dev stm32_pwm_dev_driver[PWM_CNT];
+static const char *stm32_pwm_dev_name[PWM_CNT] = {
+#if PWM_CNT > 0
+ "pwm0",
Review comment:
What if you only have PWM_0 ? This comma probably should belong in the next
if like
[here](https://github.com/apache/mynewt-core/blob/master/hw/drivers/pwm/pwm_nrf52/src/pwm_nrf52.c#L69).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
