utzig commented on a change in pull request #14: Move platform #ifdefery to <nffs/os.h> URL: https://github.com/apache/mynewt-nffs/pull/14#discussion_r242884332
########## File path: include/nffs/os.h ########## @@ -21,9 +21,29 @@ #define H_OS_ #include <stdint.h> -#if __ZEPHYR__ + +#if MYNEWT + +#include "fs/fs.h" +#include "fs/fs_if.h" +struct fs_ops nffs_ops; Review comment: Btw, that variable is just a table of functions calls. One copy or 100 won't make much difference as long as the functions are correctly pointed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
