andrzej-kaczmarek commented on a change in pull request #1550: spiflash bus
driver support
URL: https://github.com/apache/mynewt-core/pull/1550#discussion_r243067548
##########
File path: hw/drivers/flash/spiflash/src/spiflash.c
##########
@@ -628,13 +636,23 @@ static inline void spiflash_unlock(struct spiflash_dev
*dev)
static inline void
spiflash_cs_activate(struct spiflash_dev *dev)
{
+#if MYNEWT_VAL(BUS_DRIVER_PRESENT)
+ struct bus_spi_node *node = (struct bus_spi_node *)&dev->dev;
+ hal_gpio_write(node->pin_cs, 0);
Review comment:
this is redundant since `spiflash_cs_activate` is not used (?) with bus
driver as CS line is controlled automatically so perhaps it should be
ifdef'd-out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
