andrzej-kaczmarek commented on a change in pull request #1550: spiflash bus driver support URL: https://github.com/apache/mynewt-core/pull/1550#discussion_r243069612
########## File path: hw/drivers/flash/spiflash/include/spiflash/spiflash.h ########## @@ -25,17 +25,24 @@ #endif #include <hal/hal_flash_int.h> #include <hal/hal_spi.h> +#if MYNEWT_VAL(BUS_DRIVER_PRESENT) +#include <bus/spi.h> Review comment: you could rebase this on top of https://github.com/apache/mynewt-core/pull/1568/ and just include `bus/drivers/spi_common.h` here and also add dependency to `pkg.yml`: ``` pkg.deps.BUS_DRIVER_PRESENT: - "@apache-mynewt-core/hw/bus/drivers/spi_common" ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
