rymanluk commented on a change in pull request #283: Adding Periodic
Advertising Feature
URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246778276
##########
File path: nimble/host/src/ble_hs_hci_cmd.c
##########
@@ -1605,6 +1605,119 @@ ble_hs_hci_cmd_build_le_ext_adv_remove(uint8_t handle,
return 0;
}
+
+#if MYNEWT_VAL(BLE_PERIODIC_ADV)
+int
+ble_hs_hci_cmd_build_le_per_adv_params(uint8_t handle,
+
const struct hci_per_adv_params *params,
+
uint8_t *cmd, int cmd_len)
+{
+
+ BLE_HS_DBG_ASSERT(cmd_len >= BLE_HCI_LE_SET_PER_ADV_PARAMS_LEN);
+
+ cmd[0] = handle;
+
+ put_le16(&cmd[1], params->min_interval);
Review comment:
usually in this file we do HCI parameter validation. We should ad it here
and for other commands below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
