rymanluk commented on a change in pull request #283: Adding Periodic
Advertising Feature
URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246792196
##########
File path: nimble/include/nimble/hci_common.h
##########
@@ -552,9 +552,17 @@ extern "C" {
/* --- LE set periodic advertising parameters (OCF 0x003E) */
#define BLE_HCI_LE_SET_PER_ADV_PARAMS_LEN (7)
Review comment:
Looks like we also used PER_ADV, so probably this is why you use this
pattern for functions name. Can we chance all this defines to
FOO_PERIODIC_ADV_FOO?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
