brolan-juul commented on a change in pull request #2052: FCB Rotate Notification
URL: https://github.com/apache/mynewt-core/pull/2052#discussion_r336215413
##########
File path: fs/fcb/src/fcb_rotate.c
##########
@@ -49,6 +48,9 @@ fcb_rotate(struct fcb *fcb)
fcb->f_active.fe_elem_off = sizeof(struct fcb_disk_area);
fcb->f_active_id++;
}
+ if (fcb->f_scratch) {
Review comment:
If fcb->f_scratch isn't set from fcb_init(), then we would be accidentally
setting it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
