brolan-juul commented on a change in pull request #2052: FCB Rotate Notification
URL: https://github.com/apache/mynewt-core/pull/2052#discussion_r336277422
##########
File path: fs/fcb/src/fcb_append.c
##########
@@ -36,7 +57,7 @@ fcb_new_area(struct fcb *fcb, int cnt)
if (!rfa) {
rfa = fa;
}
- if (fa == fcb->f_oldest) {
+ if (fcb->f_oldest == fcb_area_past_newest(fcb)) {
Review comment:
@mkiiskila @vrahane Thoughts on handling this? I'm sure not everyone is
going to want to check a sector ahead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
