ccollins476ad commented on a change in pull request #2081: Reboot log entry
should not be in CBOR when printed on console
URL: https://github.com/apache/mynewt-core/pull/2081#discussion_r342895918
##########
File path: sys/log/util/cbor_reader/include/cbor_reader.h
##########
@@ -0,0 +1,33 @@
+/*
Review comment:
I think `log_cbor_reader` would be a better name for this directory than
`cbor_reader`. If I see
```
#include "cbor_reader.h"
```
It wouldn't occur to me that the file includes a log header.
Also, I think there should be an extra subdirectory under `include` to
maintain consistency, i.e.,
```
sys/log/util/cbor_reader/include/cbor_reader/...
```
```
#include "cbor_reader/cbor_reader.h"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
