ccollins476ad commented on a change in pull request #2081: Reboot log entry should not be in CBOR when printed on console URL: https://github.com/apache/mynewt-core/pull/2081#discussion_r342894620
########## File path: sys/log/full/src/log_console.c ########## @@ -24,9 +24,28 @@ #include <cbmem/cbmem.h> #include <console/console.h> #include "log/log.h" +#if MYNEWT_VAL(LOG_VERSION) > 2 +#include "tinycbor/cbor.h" +#include "tinycbor/cbor_buf_reader.h" +#endif static struct log log_console; +static int +console_log_dump_cbor_entry(struct log *log, const void *dptr, uint16_t len) Review comment: You could remove the first parameter to this function (`struct log *log`). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
