ccollins476ad opened a new pull request #2153: sys/config: Allow spaces in 
value passed to CLI
URL: https://github.com/apache/mynewt-core/pull/2153
 
 
   This is somewhat hacky but I think it solves the common case in a 
straightforward way.  Currently it is not possible to write a conf value 
containing spaces using the CLI.  If the user passes multiple values to the 
`config` write CLI command, e.g.,
   ```
   config id/serial firstname lastname
   ```
   
   the CLI command fails.
   
   This PR changes the config command handler so that spaces are allowed.  All 
value tokens are concatenated into a space-delimited string, and the result is 
written to the config setting.
   
   Issues with this approach:
   * All whitespace characters get converted into regular spaces.  I don't 
think this is a huge issue since it is better than not allowing spaces at all.
   
   I think anything better would be overkill (e.g., shell-style parsing).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to