ccollins476ad commented on issue #2153: sys/config: Allow spaces in value passed to CLI URL: https://github.com/apache/mynewt-core/pull/2153#issuecomment-573134827 > how about using "foo bar" syntax? That is what I meant by "shell-style parsing". That just seemed like a bit much ("overkill"). I don't think it's a deal breaker, but a quoting scheme also has backwards-compatibility implications. Tokens get split by the shell package, then the token list gets passed to the appropriate command handler (as an `argc`, `argv` pair). So any changes we make to token splitting will affect all shell commands. If we want quoting to preserve literal text, then that changes the meaning of `"` characters. If a user currently puts quotes in shell arguments, this solution would break their use case. Of course we would add a way to escape quote characters (e.g., `\"`), but again - backwards compatibility. My preference is to go with this simpler solution now. This solution is compatible with any smarter feature that gets added to the shell package, so we could always add that later as needed. If you (or anyone else) deem this as the wrong solution, I am totally fine with that - I can take a look at implementing proper argument parsing.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
