michal-narajowski commented on a change in pull request #744: [WIP] Add support 
for Enhanced LE CoC as per BT 5.2 
URL: https://github.com/apache/mynewt-nimble/pull/744#discussion_r377579945
 
 

 ##########
 File path: nimble/host/src/ble_l2cap_sig.c
 ##########
 @@ -869,6 +1267,164 @@ ble_l2cap_sig_coc_connect(uint16_t conn_handle, 
uint16_t psm, uint16_t mtu,
     return rc;
 }
 
+int
+ble_l2cap_sig_coc_connect_multiple(uint16_t conn_handle,
 
 Review comment:
   Maybe this should be named ble_l2cap_sig_coc_enhanced_connect()? I think 
this would be more clear as connect multiple could mean creating multiple 
legacy channels. And you can still use this API to create only one channel, 
so... :) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to