sjanc commented on a change in pull request #744: [WIP] Add support for Enhanced LE CoC as per BT 5.2 URL: https://github.com/apache/mynewt-nimble/pull/744#discussion_r377660646
########## File path: nimble/host/include/host/ble_l2cap.h ########## @@ -224,6 +259,13 @@ int ble_l2cap_send(struct ble_l2cap_chan *chan, struct os_mbuf *sdu_tx); int ble_l2cap_recv_ready(struct ble_l2cap_chan *chan, struct os_mbuf *sdu_rx); int ble_l2cap_get_chan_info(struct ble_l2cap_chan *chan, struct ble_l2cap_chan_info *chan_info); +/* Below API available when BLE_VERSION >= 52 */ +int ble_l2cap_enhanced_connect(uint16_t conn_handle, + uint16_t psm, uint16_t mtu, + uint8_t num, struct os_mbuf *sdu_rx[], + ble_l2cap_event_fn *cb, void *cb_arg); +int ble_l2cap_reconfig(uint16_t conn_handle, uint16_t new_mtu, Review comment: why do we need conn_handle in this api? also for this kind of API we usually provide first pointer, then count also, why is this struct ble_l2cap_chan *chans[] and not just *chans? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
