utzig commented on a change in pull request #2239: dialog_da1469x: enhance otp
and serial loader tools.
URL: https://github.com/apache/mynewt-core/pull/2239#discussion_r392383216
##########
File path: hw/bsp/dialog_da1469x-dk-pro/da1469x_serial.py
##########
@@ -51,21 +52,32 @@ def load(infile, uart):
# - If XOR matches, host sends 0x6 as final ack
# - board boots image after receiving ACK from host
-# if len(msg) == 0:
-# raise SystemExit("Read timed out, exiting")
-
- print("Please reset board to enter ROM uart recovery")
+ som_detected = False
+ reset_triggered = False
+ now = datetime.datetime.now()
Review comment:
* You could avoid having to type `datetime` twice by importing it as `from
datetime import datetime`
* `now` could be called something else like `prev`, `old` so it would be
`elapsed = datetime.now() - prev` below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
