utzig commented on a change in pull request #2239: dialog_da1469x: enhance otp
and serial loader tools.
URL: https://github.com/apache/mynewt-core/pull/2239#discussion_r392396487
##########
File path: hw/bsp/dialog_da1469x-dk-pro/otp_tool.py
##########
@@ -593,16 +616,18 @@ def test_alive_target(uart):
raise SystemExit("Failed to write to %s" % uart)
data = ser.read(rlen)
- print(data)
if len(data) != rlen:
raise SystemExit("Failed to receive response, exiting")
response = cmd_response._make(struct.unpack_from('IIII', data))
+ if response.som != 0x55aa55aa:
+ raise SystemExit("SOM not valid, invalid response")
Review comment:
Some copy/paste here. Although the checks must be done there could be a bit
or reuse so in case `0x55aa55aa` or the error message needs to change no
find/replace is required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
