utzig commented on a change in pull request #29:
URL: https://github.com/apache/mynewt-artifact/pull/29#discussion_r508078001
##########
File path: image/image.go
##########
@@ -67,6 +67,7 @@ const (
IMAGE_TLV_ENC_EC256 = 0x32
IMAGE_TLV_AES_NONCE = 0x50
IMAGE_TLV_SECRET_ID = 0x60
+ IMAGE_TLV_SECTION = 0x70
Review comment:
This should be aligned if `go fmt` was used! :-P
##########
File path: image/image.go
##########
@@ -82,6 +83,7 @@ var imageTlvTypeNameMap = map[uint8]string{
IMAGE_TLV_ENC_EC256: "ENC_EC256",
IMAGE_TLV_AES_NONCE: "AES_NONCE",
IMAGE_TLV_SECRET_ID: "SEC_KEY_ID",
+ IMAGE_TLV_SECTION: "SECTION",
Review comment:
Need to align properly
##########
File path: image/image.go
##########
@@ -67,6 +67,7 @@ const (
IMAGE_TLV_ENC_EC256 = 0x32
IMAGE_TLV_AES_NONCE = 0x50
IMAGE_TLV_SECRET_ID = 0x60
+ IMAGE_TLV_SECTION = 0x70
Review comment:
Btw, `0x50`, `0x60` and `0x70` are all downstream and not part of
MCUboot. MCUboot already has its own `0x50` and `0x60` TLVs not related to
these, so I just wonder when will the day come that you sync to MCUboot
upstream and unexpected things happen! :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
