agross-korg commented on a change in pull request #29:
URL: https://github.com/apache/mynewt-artifact/pull/29#discussion_r509536697



##########
File path: image/image.go
##########
@@ -55,33 +55,39 @@ const (
  * Image trailer TLV types.
  */
 const (
-       IMAGE_TLV_KEYHASH   = 0x01
-       IMAGE_TLV_SHA256    = 0x10
-       IMAGE_TLV_RSA2048   = 0x20
-       IMAGE_TLV_ECDSA224  = 0x21
-       IMAGE_TLV_ECDSA256  = 0x22
-       IMAGE_TLV_RSA3072   = 0x23
-       IMAGE_TLV_ED25519   = 0x24
-       IMAGE_TLV_ENC_RSA   = 0x30
-       IMAGE_TLV_ENC_KEK   = 0x31
-       IMAGE_TLV_ENC_EC256 = 0x32
-       IMAGE_TLV_AES_NONCE = 0x50
-       IMAGE_TLV_SECRET_ID = 0x60
+       IMAGE_TLV_KEYHASH          = 0x01
+       IMAGE_TLV_SHA256           = 0x10
+       IMAGE_TLV_RSA2048          = 0x20
+       IMAGE_TLV_ECDSA224         = 0x21
+       IMAGE_TLV_ECDSA256         = 0x22
+       IMAGE_TLV_RSA3072          = 0x23
+       IMAGE_TLV_ED25519          = 0x24
+       IMAGE_TLV_ENC_RSA          = 0x30
+       IMAGE_TLV_ENC_KEK          = 0x31
+       IMAGE_TLV_ENC_EC256        = 0x32
+       IMAGE_TLV_AES_NONCE_LEGACY = 0x50
+       IMAGE_TLV_SECRET_ID_LEGACY = 0x60
+       IMAGE_TLV_AES_NONCE        = 0xa1

Review comment:
       mcuboot drives the fixed TLV numbers.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to