apache-mynewt-bot commented on pull request #878: URL: https://github.com/apache/mynewt-nimble/pull/878#issuecomment-719059851
<!-- style-bot --> ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) #### nimble/transport/socket/src/ble_hci_socket.c <details> ```diff @@ -54,7 +54,7 @@ #if MYNEWT_VAL(BLE_SOCK_USE_LINUX_BLUE) #include <sys/errno.h> #define BTPROTO_HCI 1 -#define HCI_CHANNEL_RAW 0 +#define HCI_CHANNEL_RAW 0 #define HCI_CHANNEL_USER 1 #define HCIDEVUP _IOW('H', 201, int) #define HCIDEVDOWN _IOW('H', 202, int) @@ -279,7 +279,7 @@ ble_hci_sock_acl_tx(struct os_mbuf *om) { size_t len; - uint8_t* buf; + uint8_t * buf; int i; struct os_mbuf *m; struct sockaddr_hci addr; @@ -296,7 +296,7 @@ len += m->om_len; } - buf = (uint8_t*)malloc(len); + buf = (uint8_t *)malloc(len); buf[0] = BLE_HCI_UART_H4_ACL; ``` </details> #### porting/nimble/include/log_common/log_common.h <details> ```diff @@ -43,12 +43,12 @@ #define LOG_LEVEL_MAX (15) #define LOG_LEVEL_STR(level) \ - (LOG_LEVEL_DEBUG == level ? "DEBUG" :\ - (LOG_LEVEL_INFO == level ? "INFO" :\ - (LOG_LEVEL_WARN == level ? "WARN" :\ - (LOG_LEVEL_ERROR == level ? "ERROR" :\ - (LOG_LEVEL_CRITICAL == level ? "CRITICAL" :\ - "UNKNOWN"))))) + (LOG_LEVEL_DEBUG == level ? "DEBUG" : \ + (LOG_LEVEL_INFO == level ? "INFO" : \ + (LOG_LEVEL_WARN == level ? "WARN" : \ + (LOG_LEVEL_ERROR == level ? "ERROR" : \ + (LOG_LEVEL_CRITICAL == level ? "CRITICAL" : \ + "UNKNOWN"))))) /* XXX: These module IDs are defined for backwards compatibility. Application * code should use the syscfg settings directly. These defines will be removed @@ -131,8 +131,8 @@ /** @typdef log_notify_rotate_cb * @brief Callback that is executed each time we are about to rotate a log. - * - * @param log The log that is about to rotate + * + * @param log The log that is about to rotate */ typedef void log_notify_rotate_cb(const struct log *log); ``` </details> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
