v01d commented on a change in pull request #878:
URL: https://github.com/apache/mynewt-nimble/pull/878#discussion_r537682494
##########
File path: nimble/host/src/ble_hs_hci.c
##########
@@ -339,11 +339,13 @@ ble_hs_hci_cmd_tx(uint16_t opcode, const void *cmd,
uint8_t cmd_len,
static void
ble_hs_hci_rx_ack(uint8_t *ack_ev)
{
+#if 0
if (ble_npl_sem_get_count(&ble_hs_hci_sem) > 0) {
/* This ack is unexpected; ignore it. */
ble_hci_trans_buf_free(ack_ev);
return;
}
+#endif
Review comment:
I found that this check would return true unexpectedly and it would not
get to the release. It seemed to be a race condition due to the fact that the
this function would get called too fast under certain conditions. I think the
sequence was that the lock was actually set after the if check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
