sjanc commented on a change in pull request #878:
URL: https://github.com/apache/mynewt-nimble/pull/878#discussion_r542217425



##########
File path: porting/nimble/include/log/log.h
##########
@@ -30,11 +30,13 @@ log_dummy(void *log, ...)
     (void)log;
 }
 
+#if 0

Review comment:
       Hmm I think for now we could just put all this under #ifndef LOG_DEBUG
   
   in long term I think we should add own NPL_LOG_* and use those instead of 
relying on modlog module defining those




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to