v01d commented on a change in pull request #878:
URL: https://github.com/apache/mynewt-nimble/pull/878#discussion_r543490513
##########
File path: porting/nimble/include/log/log.h
##########
@@ -30,11 +30,13 @@ log_dummy(void *log, ...)
(void)log;
}
+#if 0
Review comment:
I think that would require an include to be present before defining
LOG_DEBUG which may not always be the case. What about `#if MYNEWT`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
