t3zeng commented on pull request #2686: URL: https://github.com/apache/mynewt-core/pull/2686#issuecomment-929491078
> @vrahane I said explicitly that I do not like idea of having that package in **Mynewt tree**. I do not have any issue with adding APIs to support it, thus proposed callback, and I do not want to restrict anyone from using Memfault or any other tool with Mynewt, not even sure how you came to such a ridiculous conclusion. > > Once we add `os_coredump_cb`, adding required support to Memfault repository is trivial and imo it's the best way to do this: we **do not need to maintain** it and we have **proper** support that we can advertise e.g. on webpage. Otherwise, as proposed here, we have a package that requires a 3rd party repo that includes some fork of actual memfault-sdk repo... good luck with maintaining that. There are some misconceptions here. First off, the purpose of the wrapper repo is to house the necessary mynewt repo yaml files. This is there because mynewt only allows for the repo files to be at the top level and it provides the power to choose when to update the commit hash in case things break. Second, it currently includes some fork of the actual memfault-sdk right now because that fork contains changes that I am currently working on merging into the official memfault-sdk repo. Once that merge is complete, the wrapper repo will host the official memfault-sdk repo and not some fork. Taking out the memfault package from mynewt tree does not eliminate the need for the wrapper repo because you still need to pull in the memfault repo to mynewt to use it. The only difference is in your proposed solution the coredump callback is defined in the memfault sdk, users need to use the internet to search for what callback functions are available for them to use, and any changes to the mechanism on mynewt side will break all packages that leverage the new coredump callback since they will all live outside of mynewt. What removing the memfault package from mynewt-core doesn't change is the need to have a repo that has the yaml files needed for mynewt to recognize it as a repo that can be pulled in for use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
