t3zeng commented on pull request #2686: URL: https://github.com/apache/mynewt-core/pull/2686#issuecomment-930429410
> > Getting rid of the intermediate repo has no bearing to the changes in mynewt. All that changes is the path of the package that's included which is a very minor difference not worth fixating on in the context of this review. > > Why would I want to pull in `proxyco/mynewt-memfault-sdk` instead of just using `memfault/memfault-firmware-sdk` directly? Why not PR the yaml files there? And btw, I think `version.yml` is not required anymore. Okay I can get rid of `version.yml` thanks. The wrapper repo is mainly because the memfault people didn't like that the yaml is required to be at the top level but it also acts as an anchor to commit ids that we know work well with mynewt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
