KKopyscinski commented on code in PR #1619:
URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1371326238


##########
nimble/host/services/auracast/include/services/auracast/ble_svc_auracast.h:
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <stdint.h>
+#include "host/ble_gap.h"
+#include "host/ble_audio_common.h"
+#include "host/ble_audio_broadcast.h"
+
+struct ble_svc_auracast_create_params {
+    struct ble_audio_base *base;
+    struct ble_iso_big_params *big_params;
+    const char *name;
+    uint8_t adv_instance;
+};
+
+/**
+ * @brief Create Auracast Endpoint and configure advertising instance
+ *
+ * This function configures advertising instance for extended and periodic
+ * advertisements to be ready for Auracast broadcast.
+ *
+ * @param[in] params            Pointer to a `ble_svc_auracast_create_params`
+ *                              structure that defines BIG and broadcast name.
+ * @param[out] config_out       Pointer to a `ble_broadcast_base_config`
+ *                              structure to return configuration of created
+ *                              Auracast advertisement.
+ * @param[in] destroy_cb        Optional callback to be called when Auracast
+ *                              advertisement is destroyed.
+ * @param[in] args              Optional arguments to be passed to `destroy_cb`
+ * @param[in] gap_cb            GAP event callback to be associated with
+ *                              Auracast advertisement.
+ *
+ * @return                      0 on success;
+ *                              A non-zero value on failure.
+ */
+int ble_svc_auracast_create(const struct
+                            ble_svc_auracast_create_params *params,
+                            struct ble_broadcast_base_config *config_out,

Review Comment:
   I agree and my response is also the same :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to