rymanluk commented on code in PR #1619:
URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1375800333


##########
nimble/host/include/host/ble_audio_common.h:
##########
@@ -0,0 +1,183 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#ifndef H_BLE_AUDIO_COMMON_
+#define H_BLE_AUDIO_COMMON_
+
+#include "stdint.h"
+#include "os/queue.h"
+
+#define BLE_BROADCAST_AUDIO_ANNOUNCEMENT_SVC_UUID               0x1852
+
+#define BLE_BROADCAST_SAMPLING_RATE_8000_HZ                           BIT(0)
+#define BLE_BROADCAST_SAMPLING_RATE_11025_HZ                          BIT(1)
+#define BLE_BROADCAST_SAMPLING_RATE_16000_HZ                          BIT(2)
+#define BLE_BROADCAST_SAMPLING_RATE_22050_HZ                          BIT(3)
+#define BLE_BROADCAST_SAMPLING_RATE_24000_HZ                          BIT(4)
+#define BLE_BROADCAST_SAMPLING_RATE_32000_HZ                          BIT(5)
+#define BLE_BROADCAST_SAMPLING_RATE_44100_HZ                          BIT(6)
+#define BLE_BROADCAST_SAMPLING_RATE_48000_HZ                          BIT(7)
+#define BLE_BROADCAST_SAMPLING_RATE_88200_HZ                          BIT(8)
+#define BLE_BROADCAST_SAMPLING_RATE_96000_HZ                          BIT(9)
+#define BLE_BROADCAST_SAMPLING_RATE_176400_HZ                         BIT(10)
+#define BLE_BROADCAST_SAMPLING_RATE_192000_HZ                         BIT(11)
+#define BLE_BROADCAST_SAMPLING_RATE_384000_HZ                         BIT(12)
+
+#define BLE_BROADCAST_SUPPORTED_FRAME_DURATION_7_5_MS                 BIT(0)
+#define BLE_BROADCAST_SUPPORTED_FRAME_DURATION_10_MS                  BIT(1)
+
+#define BLE_BROADCAST_AUDIO_LOCATION_FRONT_LEFT                       BIT(0)
+#define BLE_BROADCAST_AUDIO_LOCATION_FRONT_RIGHT                      BIT(1)
+#define BLE_BROADCAST_AUDIO_LOCATION_FRONT_CENTER                     BIT(2)
+#define BLE_BROADCAST_AUDIO_LOCATION_LOW_FREQ_EFFECTS_1               BIT(3)
+#define BLE_BROADCAST_AUDIO_LOCATION_BACK_LEFT                        BIT(4)
+#define BLE_BROADCAST_AUDIO_LOCATION_FRONT_LEFT_CENTER                BIT(5)
+#define BLE_BROADCAST_AUDIO_LOCATION_FRONT_RIGHT_CENTER               BIT(6)
+#define BLE_BROADCAST_AUDIO_LOCATION_BACK_CENTER                      BIT(7)
+#define BLE_BROADCAST_AUDIO_LOCATION_LOW_FREQ_EFFECTS_2               BIT(8)
+#define BLE_BROADCAST_AUDIO_LOCATION_SIDE_LEFT                        BIT(9)
+#define BLE_BROADCAST_AUDIO_LOCATION_SIDE_RIGHT                       BIT(10)
+#define BLE_BROADCAST_AUDIO_LOCATION_TOP_FRONT_LEFT                   BIT(11)
+#define BLE_BROADCAST_AUDIO_LOCATION_TOP_FRONT_RIGHT                  BIT(12)
+#define BLE_BROADCAST_AUDIO_LOCATION_TOP_FRONT_CENTER                 BIT(13)
+#define BLE_BROADCAST_AUDIO_LOCATION_TOP_CENTER                       BIT(14)
+#define BLE_BROADCAST_AUDIO_LOCATION_TOP_BACK_LEFT                    BIT(15)
+#define BLE_BROADCAST_AUDIO_LOCATION_TOP_BACK_RIGHT                   BIT(16)
+#define BLE_BROADCAST_AUDIO_LOCATION_TOP_SIDE_LEFT                    BIT(17)
+#define BLE_BROADCAST_AUDIO_LOCATION_TOP_SIDE_RIGHT                   BIT(18)
+#define BLE_BROADCAST_AUDIO_LOCATION_TOP_BACK_CENTER                  BIT(19)
+#define BLE_BROADCAST_AUDIO_LOCATION_BOTTOM_FRONT_CENTER              BIT(20)
+#define BLE_BROADCAST_AUDIO_LOCATION_BOTTOM_FRONT_LEFT                BIT(21)
+#define BLE_BROADCAST_AUDIO_LOCATION_BOTTOM_FRONT_RIGHT               BIT(22)
+#define BLE_BROADCAST_AUDIO_LOCATION_LEFT_SURROUND                    BIT(23)
+#define BLE_BROADCAST_AUDIO_LOCATION_RIGHT_SURROUND                   BIT(24)
+
+struct ble_audio_codec_id {
+    /** Coding Fromat */
+    uint8_t format;
+
+    /** Company ID */
+    uint16_t company_id;
+
+    /** Vendor Specific Codec ID */
+    uint16_t vendor_specific;
+};
+
+struct ble_audio_bis {

Review Comment:
   agree with @KKopyscinski 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to