rymanluk commented on code in PR #986:
URL: https://github.com/apache/mynewt-nimble/pull/986#discussion_r1485628446
##########
apps/blestress/syscfg.yml:
##########
@@ -75,3 +75,6 @@ syscfg.vals:
# Whether to save data to sys/config, or just keep it in RAM.
BLE_STORE_CONFIG_PERSIST: 0
+
+ # ACL buf size must be able to contain CoC MPS plus ACL header
+ BLE_ACL_BUF_SIZE: MYNEWT_VAL_BLE_L2CAP_COC_MPS+4
Review Comment:
shouldn't it be (MYNEWT_VAL(MYNEWT_VAL_BLE_L2CAP_COC_MPS) + 4 ) ?
##########
apps/blestress/syscfg.yml:
##########
@@ -75,3 +75,6 @@ syscfg.vals:
# Whether to save data to sys/config, or just keep it in RAM.
BLE_STORE_CONFIG_PERSIST: 0
+
+ # ACL buf size must be able to contain CoC MPS plus ACL header
+ BLE_ACL_BUF_SIZE: MYNEWT_VAL_BLE_L2CAP_COC_MPS+4
Review Comment:
shouldn't it be (MYNEWT_VAL(BLE_L2CAP_COC_MPS) + 4 ) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
