KKopyscinski commented on code in PR #986:
URL: https://github.com/apache/mynewt-nimble/pull/986#discussion_r1485787601


##########
apps/blestress/syscfg.yml:
##########
@@ -75,3 +75,6 @@ syscfg.vals:
 
     # Whether to save data to sys/config, or just keep it in RAM.
     BLE_STORE_CONFIG_PERSIST: 0
+
+    # ACL buf size must be able to contain CoC MPS plus ACL header
+    BLE_ACL_BUF_SIZE: MYNEWT_VAL_BLE_L2CAP_COC_MPS+4

Review Comment:
   This incorrectly expands to
   ``` c
   #define MYNEWT_VAL_BLE_TRANSPORT_ACL_SIZE (MYNEWT_VAL_MSYS_1_BLOCK_SIZE-8)
   ```
   and ignores +4. So we need to use `MYNEWT_VAL_` variant. I think it's the 
same as for `BLE_L2CAP_COC_MPS` definition in `nimble/host/syscfg.yml`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to