mkiiskila commented on a change in pull request #318: MYNEWT-681 remove flash 
write protection in download scripts 
URL: 
https://github.com/apache/incubator-mynewt-core/pull/318#discussion_r120980684
 
 

 ##########
 File path: hw/bsp/rb-nano2/rb-nano2_download.sh
 ##########
 @@ -37,6 +37,15 @@ if [ "$MFG_IMAGE" ]; then
     FLASH_OFFSET=0
 fi
 
+# We write the config registers for BPROT so that NVMC write
+# protection gets disabled for all blocks of the flash
+# We also write the DISABLEINDEBUG register so that, write
+# protection gets disabled in debug register by default
+EXTRA_GDB_CMDS="set {unsigned long}0x40000600=0;set {unsigned 
long}0x40000604=0;\
 
 Review comment:
   Did you mean CFG_POST_INIT instead of EXTRA_GDB_CMDS?
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to