mkiiskila commented on a change in pull request #318: MYNEWT-681 remove flash
write protection in download scripts
URL:
https://github.com/apache/incubator-mynewt-core/pull/318#discussion_r121307258
##########
File path: hw/scripts/openocd.sh
##########
@@ -101,7 +101,9 @@ openocd_debug () {
if [ ! -z "$RESET" ]; then
echo "mon reset halt" >> $GDB_CMD_FILE
fi
- echo "FILENAME" $FILE_NAME >>out
+ echo "$EXTRA_GDB_CMDS" >> $GDB_CMD_FILE
+ echo "FILENAME" $FILE_NAME >>out
Review comment:
I don't see a reason for this line. Why is it here? Could it be removed as
part of this commit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
