[ 
https://issues.apache.org/jira/browse/NETBEANS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108061#comment-17108061
 ] 

Svatopluk Dedic commented on NETBEANS-2082:
-------------------------------------------

[~errael]
{quote}It seems preferable if a fix for "Folding > Collapse by Default" could 
be localized to that feature (wherever that code might be) rather than spread 
across caret handling.
{quote}
The *code folding* module has (or should have) no access to the Editor 
JComponent and its viewport. If it had, it would interfere with other tools 
that may have the same bright idea to manipulate with the view. It's job ends 
by firing an appropriate change event on the EditorViewFactory. It's the 
*Editor* module & co., which manages individual EditorViews, recomputes the 
text layout ... and attempts to reposition the viewport to show the 'current 
place' in the editor. 

The property was a way how to get the editor a "hint" what's going on to react 
properly when it decides to "do something" about the caret and viewport. If the 
tools bring more such competing ideas, an additional editor API would be 
appropriate to collect & combine such hints.

The issue here is that the hint is either insufficient, or is given in 
different conditions than it should.

 

> Scroll to the caret position when code fold feature is run
> ----------------------------------------------------------
>
>                 Key: NETBEANS-2082
>                 URL: https://issues.apache.org/jira/browse/NETBEANS-2082
>             Project: NetBeans
>          Issue Type: Bug
>          Components: editor - Code folding
>    Affects Versions: 10.0, 11.0, 11.1, 11.2
>         Environment: Netbeans 11 with OpenJDK 12. 
> Darwin MacBook-Pro-2.local 18.5.0 Darwin Kernel Version 18.5.0: Mon Mar 11 
> 20:40:32 PDT 2019; root:xnu-4903.251.3~3/RELEASE_X86_64 x86_64
> Netbeans 10 with OpenJDK 11.
> Darwin MacBook-Pro-2.local 18.2.0 Darwin Kernel Version 18.2.0: Thu Dec 20 
> 20:46:53 PST 2018; root:xnu-4903.241.1~1/RELEASE_X86_64 x86_64
>            Reporter: Pier Luigi
>            Assignee: Svatopluk Dedic
>            Priority: Critical
>         Attachments: DemoPHPCodeFoldingProblem_NB11.php, NETBEANS-2082.zip, 
> netbeans-2082.gif
>
>
> Collapsing a block often results in a jump of the editor to an incorrect 
> editing position (and scrolling the page cause a rejump to that position 
> after a second of scroll inactivity).
> The same sources works perfectly with Netbeans 8.2.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to