[
https://issues.apache.org/jira/browse/NETBEANS-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239516#comment-16239516
]
ASF GitHub Bot commented on NETBEANS-112:
-----------------------------------------
lbruun commented on issue #241: [NETBEANS-112] Re-integrate DTD for RSS 0.91
feed
URL:
https://github.com/apache/incubator-netbeans/pull/241#issuecomment-341971016
Matthias, I understand where you are coming from but as I read the ASF rules
it is acceptable to have such a file in the distribution (even without a
license header) as long as it meets the criteria:
- Small
- Consumed at runtime
- Unmodified
- Static - will never change
- Constitutes a specification of a standard
- File is appropriately labeled
This is my interpretation of
> For small amounts of source that is directly consumed by the ASF product
> at runtime in source form, and for which that source is unmodified and
> unlikely to be changed anyway (say, by virtue of being specified by a
> standard), inclusion of appropriately labeled source is also permitted.
> An example of this is the web-facesconfig_1_0.dtd, whose inclusion is
> mandated by the JSR 127: JavaServer Faces specification.
Your proposed fix will certainly work too, although I'm concerned it will
re-read the DTD file for _every_ parse operation.
Perhaps a good "test case" to ask the mentor(s) about, assuming there will
be more of this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Welcome module (RSS) feed broken in donation
> --------------------------------------------
>
> Key: NETBEANS-112
> URL: https://issues.apache.org/jira/browse/NETBEANS-112
> Project: NetBeans
> Issue Type: Bug
> Components: ide - Welcome
> Reporter: lbruun
> Priority: Minor
> Labels: pull-request-available
> Attachments: NB-2017.png
>
>
> !NB-2017.png!
> In Apache NetBeans the RSS feeds in Welcome Page no longer works. Works on
> current hg main-silver and works in NB 8.2.
> The problem occurs when the downloaded XML has a doctype declaration:
> {code:xml}
> <!DOCTYPE rss PUBLIC "-//Netscape Communications//DTD RSS 0.91//EN"
> "http://my.netscape.com/publish/formats/rss-0.91.dtd";>
> {code}
> There used to be a "registered" DTD for this in the Welcome module but it was
> removed as part of Oracle's cleanup prior to donation. This is why it works
> on current hg main-silver, but not on the donated code.
> See:
> http://hg.netbeans.org/releases/rev/66633aaa2811
> http://hg.netbeans.org/releases/rev/00ff3249694f
> Because of the removal, the XML Reader will - in the absence of a registered
> DTD - attempt to download the DTD from the Internet, i.e. it will attempt to
> download http://my.netscape.com/publish/formats/rss-0.91.dtd, which will fail
> because it redirects to {{aol.com}} and there isn't a DTD at that location.
> (duh!, I'm actually surprised that {{netscape.com}} still exists and forwards
> to {{aol.com}}, it's been 18 years since the acquisition !)
> The RSS feed from planetnetbeans.org (right side of screenshot) doesn't have
> a DOCTYPE declaration which is why it works.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
