[
https://issues.apache.org/jira/browse/NETBEANS-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239643#comment-16239643
]
ASF GitHub Bot commented on NETBEANS-112:
-----------------------------------------
matthiasblaesing closed pull request #241: [NETBEANS-112] Re-integrate DTD for
RSS 0.91 feed
URL: https://github.com/apache/incubator-netbeans/pull/241
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/nbbuild/build.xml b/nbbuild/build.xml
index 12bd9ada1..445ccfe2a 100644
--- a/nbbuild/build.xml
+++ b/nbbuild/build.xml
@@ -2057,6 +2057,7 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y
to start the system in d
<exclude
name="websvc.saas.api/test/unit/src/org/netbeans/modules/websvc/saas/model/application.wadl"
/> <!--test data-->
<exclude
name="websvc.saas.api/test/unit/src/org/netbeans/modules/websvc/saas/util/rootGroup.xml"
/> <!--test data-->
<exclude name="websvc.saas.kit/release/VERSION.txt" />
<!--generated file-->
+ <exclude
name="welcome/src/org/netbeans/modules/welcome/resources/rss-0_91.dtd" /> <!--
specifies a standard -->
<exclude
name="xml.axi/test/unit/src/org/netbeans/modules/xml/axi/resources/**" /> <!--
test data -->
<exclude
name="xml.lexer/test/unit/src/org/netbeans/api/xml/lexer/resources/*.dtd" />
<!-- test data -->
<exclude
name="xml.lexer/test/unit/src/org/netbeans/api/xml/lexer/resources/*.xml" />
<!-- test data -->
diff --git a/welcome/src/org/netbeans/modules/welcome/resources/layer.xml
b/welcome/src/org/netbeans/modules/welcome/resources/layer.xml
index 46df3cf46..fed33a5c2 100644
--- a/welcome/src/org/netbeans/modules/welcome/resources/layer.xml
+++ b/welcome/src/org/netbeans/modules/welcome/resources/layer.xml
@@ -95,14 +95,14 @@
public IDs to filesystem constructs (files and folders).
-->
-<!-- <folder name="entities">
+ <folder name="entities">
<folder name="Netscape_Communications">
<file name="DTD_RSS_0_91" url="rss-0_91.dtd">
<attr name="hint.originalPublicID"
stringvalue="-//Netscape Communications//DTD RSS 0.91//EN"/>
</file>
</folder>
- </folder>-->
+ </folder>
</folder>
diff --git a/welcome/src/org/netbeans/modules/welcome/resources/rss-0_91.dtd
b/welcome/src/org/netbeans/modules/welcome/resources/rss-0_91.dtd
new file mode 100644
index 000000000..91066ae8b
--- /dev/null
+++ b/welcome/src/org/netbeans/modules/welcome/resources/rss-0_91.dtd
@@ -0,0 +1,175 @@
+<!--
+ Downloaded from http://www.rssboard.org/rss-0.91.dtd
+ by Apache NetBeans project, 2017-11-04.
+-->
+<!--
+
+ Rich Site Summary (RSS) 0.91 official DTD, proposed.
+
+ RSS is an XML vocabulary for describing
+ metadata about websites, and enabling the display of
+ "channels" on the "My Netscape" website.
+
+ RSS Info can be found at http://channel.netscape.com/publish/
+ XML Info can be found at http://www.w3.org/XML/
+
+ copyright Netscape Communications, 1999
+
+ Dan Libby - da...@netscape.com
+
+ Based on RSS DTD originally created by
+ Lars Marius Garshol - lar...@ifi.uio.no.
+ $Id: rss-0.91.dtd,v 1.2 2001/04/26 03:02:34 eedrin Exp $
+
+-->
+
+<!ELEMENT rss (channel)>
+<!ATTLIST rss
+ version CDATA #REQUIRED> <!-- must be "0.91"> -->
+
+<!ELEMENT channel (title | description | link | language | item+ | rating? |
image? | textinput? | copyright? | pubDate? | lastBuildDate? | docs? |
managingEditor? | webMaster? | skipHours? | skipDays?)*>
+<!ELEMENT title (#PCDATA)>
+<!ELEMENT description (#PCDATA)>
+<!ELEMENT link (#PCDATA)>
+<!ELEMENT image (title | url | link | width? | height? | description?)*>
+<!ELEMENT url (#PCDATA)>
+<!ELEMENT item (title | link | description)*>
+<!ELEMENT textinput (title | description | name | link)*>
+<!ELEMENT name (#PCDATA)>
+<!ELEMENT rating (#PCDATA)>
+<!ELEMENT language (#PCDATA)>
+<!ELEMENT width (#PCDATA)>
+<!ELEMENT height (#PCDATA)>
+<!ELEMENT copyright (#PCDATA)>
+<!ELEMENT pubDate (#PCDATA)>
+<!ELEMENT lastBuildDate (#PCDATA)>
+<!ELEMENT docs (#PCDATA)>
+<!ELEMENT managingEditor (#PCDATA)>
+<!ELEMENT webMaster (#PCDATA)>
+<!ELEMENT hour (#PCDATA)>
+<!ELEMENT day (#PCDATA)>
+<!ELEMENT skipHours (hour+)>
+<!ELEMENT skipDays (day+)>
+
+<!--
+ Copied from HTML 3.2 DTD, with modifications (removed CDATA)
+ http://www.w3.org/TR/REC-html32.html#dtd
+ =============== BEGIN ===================
+-->
+<!--
+ Character Entities for ISO Latin-1
+
+ (C) International Organization for Standardization 1986
+ Permission to copy in any form is granted for use with
+ conforming SGML systems and applications as defined in
+ ISO 8879, provided this notice is included in all copies.
+ This has been extended for use with HTML to cover the full
+ set of codes in the range 160-255 decimal.
+-->
+<!-- Character entity set. Typical invocation:
+ <!ENTITY % ISOlat1 PUBLIC
+ "ISO 8879-1986//ENTITIES Added Latin 1//EN//HTML">
+ %ISOlat1;
+-->
+ <!ENTITY nbsp " "> <!-- no-break space -->
+ <!ENTITY iexcl "¡"> <!-- inverted exclamation mark -->
+ <!ENTITY cent "¢"> <!-- cent sign -->
+ <!ENTITY pound "£"> <!-- pound sterling sign -->
+ <!ENTITY curren "¤"> <!-- general currency sign -->
+ <!ENTITY yen "¥"> <!-- yen sign -->
+ <!ENTITY brvbar "¦"> <!-- broken (vertical) bar -->
+ <!ENTITY sect "§"> <!-- section sign -->
+ <!ENTITY uml "¨"> <!-- umlaut (dieresis) -->
+ <!ENTITY copy "©"> <!-- copyright sign -->
+ <!ENTITY ordf "ª"> <!-- ordinal indicator, feminine -->
+ <!ENTITY laquo "«"> <!-- angle quotation mark, left -->
+ <!ENTITY not "¬"> <!-- not sign -->
+ <!ENTITY shy "­"> <!-- soft hyphen -->
+ <!ENTITY reg "®"> <!-- registered sign -->
+ <!ENTITY macr "¯"> <!-- macron -->
+ <!ENTITY deg "°"> <!-- degree sign -->
+ <!ENTITY plusmn "±"> <!-- plus-or-minus sign -->
+ <!ENTITY sup2 "²"> <!-- superscript two -->
+ <!ENTITY sup3 "³"> <!-- superscript three -->
+ <!ENTITY acute "´"> <!-- acute accent -->
+ <!ENTITY micro "µ"> <!-- micro sign -->
+ <!ENTITY para "¶"> <!-- pilcrow (paragraph sign) -->
+ <!ENTITY middot "·"> <!-- middle dot -->
+ <!ENTITY cedil "¸"> <!-- cedilla -->
+ <!ENTITY sup1 "¹"> <!-- superscript one -->
+ <!ENTITY ordm "º"> <!-- ordinal indicator, masculine -->
+ <!ENTITY raquo "»"> <!-- angle quotation mark, right -->
+ <!ENTITY frac14 "¼"> <!-- fraction one-quarter -->
+ <!ENTITY frac12 "½"> <!-- fraction one-half -->
+ <!ENTITY frac34 "¾"> <!-- fraction three-quarters -->
+ <!ENTITY iquest "¿"> <!-- inverted question mark -->
+ <!ENTITY Agrave "À"> <!-- capital A, grave accent -->
+ <!ENTITY Aacute "Á"> <!-- capital A, acute accent -->
+ <!ENTITY Acirc "Â"> <!-- capital A, circumflex accent -->
+ <!ENTITY Atilde "Ã"> <!-- capital A, tilde -->
+ <!ENTITY Auml "Ä"> <!-- capital A, dieresis or umlaut mark -->
+ <!ENTITY Aring "Å"> <!-- capital A, ring -->
+ <!ENTITY AElig "Æ"> <!-- capital AE diphthong (ligature) -->
+ <!ENTITY Ccedil "Ç"> <!-- capital C, cedilla -->
+ <!ENTITY Egrave "È"> <!-- capital E, grave accent -->
+ <!ENTITY Eacute "É"> <!-- capital E, acute accent -->
+ <!ENTITY Ecirc "Ê"> <!-- capital E, circumflex accent -->
+ <!ENTITY Euml "Ë"> <!-- capital E, dieresis or umlaut mark -->
+ <!ENTITY Igrave "Ì"> <!-- capital I, grave accent -->
+ <!ENTITY Iacute "Í"> <!-- capital I, acute accent -->
+ <!ENTITY Icirc "Î"> <!-- capital I, circumflex accent -->
+ <!ENTITY Iuml "Ï"> <!-- capital I, dieresis or umlaut mark -->
+ <!ENTITY ETH "Ð"> <!-- capital Eth, Icelandic -->
+ <!ENTITY Ntilde "Ñ"> <!-- capital N, tilde -->
+ <!ENTITY Ograve "Ò"> <!-- capital O, grave accent -->
+ <!ENTITY Oacute "Ó"> <!-- capital O, acute accent -->
+ <!ENTITY Ocirc "Ô"> <!-- capital O, circumflex accent -->
+ <!ENTITY Otilde "Õ"> <!-- capital O, tilde -->
+ <!ENTITY Ouml "Ö"> <!-- capital O, dieresis or umlaut mark -->
+ <!ENTITY times "×"> <!-- multiply sign -->
+ <!ENTITY Oslash "Ø"> <!-- capital O, slash -->
+ <!ENTITY Ugrave "Ù"> <!-- capital U, grave accent -->
+ <!ENTITY Uacute "Ú"> <!-- capital U, acute accent -->
+ <!ENTITY Ucirc "Û"> <!-- capital U, circumflex accent -->
+ <!ENTITY Uuml "Ü"> <!-- capital U, dieresis or umlaut mark -->
+ <!ENTITY Yacute "Ý"> <!-- capital Y, acute accent -->
+ <!ENTITY THORN "Þ"> <!-- capital THORN, Icelandic -->
+ <!ENTITY szlig "ß"> <!-- small sharp s, German (sz ligature) -->
+ <!ENTITY agrave "à"> <!-- small a, grave accent -->
+ <!ENTITY aacute "á"> <!-- small a, acute accent -->
+ <!ENTITY acirc "â"> <!-- small a, circumflex accent -->
+ <!ENTITY atilde "ã"> <!-- small a, tilde -->
+ <!ENTITY auml "ä"> <!-- small a, dieresis or umlaut mark -->
+ <!ENTITY aring "å"> <!-- small a, ring -->
+ <!ENTITY aelig "æ"> <!-- small ae diphthong (ligature) -->
+ <!ENTITY ccedil "ç"> <!-- small c, cedilla -->
+ <!ENTITY egrave "è"> <!-- small e, grave accent -->
+ <!ENTITY eacute "é"> <!-- small e, acute accent -->
+ <!ENTITY ecirc "ê"> <!-- small e, circumflex accent -->
+ <!ENTITY euml "ë"> <!-- small e, dieresis or umlaut mark -->
+ <!ENTITY igrave "ì"> <!-- small i, grave accent -->
+ <!ENTITY iacute "í"> <!-- small i, acute accent -->
+ <!ENTITY icirc "î"> <!-- small i, circumflex accent -->
+ <!ENTITY iuml "ï"> <!-- small i, dieresis or umlaut mark -->
+ <!ENTITY eth "ð"> <!-- small eth, Icelandic -->
+ <!ENTITY ntilde "ñ"> <!-- small n, tilde -->
+ <!ENTITY ograve "ò"> <!-- small o, grave accent -->
+ <!ENTITY oacute "ó"> <!-- small o, acute accent -->
+ <!ENTITY ocirc "ô"> <!-- small o, circumflex accent -->
+ <!ENTITY otilde "õ"> <!-- small o, tilde -->
+ <!ENTITY ouml "ö"> <!-- small o, dieresis or umlaut mark -->
+ <!ENTITY divide "÷"> <!-- divide sign -->
+ <!ENTITY oslash "ø"> <!-- small o, slash -->
+ <!ENTITY ugrave "ù"> <!-- small u, grave accent -->
+ <!ENTITY uacute "ú"> <!-- small u, acute accent -->
+ <!ENTITY ucirc "û"> <!-- small u, circumflex accent -->
+ <!ENTITY uuml "ü"> <!-- small u, dieresis or umlaut mark -->
+ <!ENTITY yacute "ý"> <!-- small y, acute accent -->
+ <!ENTITY thorn "þ"> <!-- small thorn, Icelandic -->
+ <!ENTITY yuml "ÿ"> <!-- small y, dieresis or umlaut mark -->
+
+<!--
+ Copied from HTML 3.2 DTD, with modifications (removed CDATA)
+ http://www.w3.org/TR/REC-html32.html#dtd
+ ================= END ===================
+-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Welcome module (RSS) feed broken in donation
> --------------------------------------------
>
> Key: NETBEANS-112
> URL: https://issues.apache.org/jira/browse/NETBEANS-112
> Project: NetBeans
> Issue Type: Bug
> Components: ide - Welcome
> Reporter: lbruun
> Priority: Minor
> Labels: pull-request-available
> Attachments: NB-2017.png
>
>
> !NB-2017.png!
> In Apache NetBeans the RSS feeds in Welcome Page no longer works. Works on
> current hg main-silver and works in NB 8.2.
> The problem occurs when the downloaded XML has a doctype declaration:
> {code:xml}
> <!DOCTYPE rss PUBLIC "-//Netscape Communications//DTD RSS 0.91//EN"
> "http://my.netscape.com/publish/formats/rss-0.91.dtd";>
> {code}
> There used to be a "registered" DTD for this in the Welcome module but it was
> removed as part of Oracle's cleanup prior to donation. This is why it works
> on current hg main-silver, but not on the donated code.
> See:
> http://hg.netbeans.org/releases/rev/66633aaa2811
> http://hg.netbeans.org/releases/rev/00ff3249694f
> Because of the removal, the XML Reader will - in the absence of a registered
> DTD - attempt to download the DTD from the Internet, i.e. it will attempt to
> download http://my.netscape.com/publish/formats/rss-0.91.dtd, which will fail
> because it redirects to {{aol.com}} and there isn't a DTD at that location.
> (duh!, I'm actually surprised that {{netscape.com}} still exists and forwards
> to {{aol.com}}, it's been 18 years since the acquisition !)
> The RSS feed from planetnetbeans.org (right side of screenshot) doesn't have
> a DOCTYPE declaration which is why it works.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
