[
https://issues.apache.org/jira/browse/NETBEANS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244809#comment-16244809
]
ASF GitHub Bot commented on NETBEANS-129:
-----------------------------------------
geertjanw closed pull request #260: [NETBEANS-129] For source zips, alter the
nbbuild/cluster.properties …
URL: https://github.com/apache/incubator-netbeans/pull/260
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/nbbuild/build.xml b/nbbuild/build.xml
index db1024677..121e12e04 100644
--- a/nbbuild/build.xml
+++ b/nbbuild/build.xml
@@ -1515,14 +1515,24 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y
to start the system in d
</concat>
<taskdef name="createdependencies"
classname="org.netbeans.nbbuild.extlibs.CreateDependencies"
classpath="${nbantext.jar}"/>
<createdependencies refid="source.dirset"
dependencies="${nb.build.dir}/DEPENDENCIES" sourceDependencies="true"/>
+ <concat destfile="${nb.build.dir}/cluster.properties">
+ <fileset file="${nb_all}/nbbuild/cluster.properties" />
+ <filterchain>
+ <tokenfilter>
+ <replaceregex pattern="cluster.config=.*"
replace="cluster.config=${cluster.config}" />
+ </tokenfilter>
+ </filterchain>
+ </concat>
<zip zipfile="${nb.build.dir}/${cluster.config}-src-${buildnum}.zip"
duplicate="preserve">
<zipfileset dir="${nb_all}" includes="${source.dirs}">
<exclude name="*/build/**/*"/>
<exclude name="nbbuild/netbeans/**"/>
+ <exclude name="nbbuild/cluster.properties" />
</zipfileset>
<zipfileset dir="${nb_all}">
<include name="build.xml"/>
</zipfileset>
+ <zipfileset file="${nb.build.dir}/cluster.properties"
fullpath="nbbuild/cluster.properties" />
<zipfileset file="${nb.build.dir}/DEPENDENCIES" />
<zipfileset file="${nb.build.dir}/NOTICE" />
<zipfileset file="${nb.build.dir}/LICENSE" />
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> What is one supposed to do with netbeans-platform-source.zip?
> -------------------------------------------------------------
>
> Key: NETBEANS-129
> URL: https://issues.apache.org/jira/browse/NETBEANS-129
> Project: NetBeans
> Issue Type: Bug
> Reporter: Jaroslav Tulach
> Priority: Minor
> Labels: pull-request-available
>
> Build source build #63 of
> https://builds.apache.org/view/Incubator%20Projects/job/incubator-netbeans-release/
> has, in my opinion, several problems:
> - there is no {{README}} - e.g. even experienced NetBeans guys don't know
> what to expect (witnessed on Tomáš H. and Jirka S.)
> - there is {{build.xml}} - so one might be tempted to execute it - but that
> fails - it would be good if the default {{cluster.config}} was {{platform}}
> in this case as {{ant -Dcluster.config=platform}} succeeds
> - the sources in the zip file aren't in a root subdirectory - unusual and
> very annoying if one just unzips the file.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
