[
https://issues.apache.org/jira/browse/NETBEANS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258630#comment-16258630
]
ASF GitHub Bot commented on NETBEANS-161:
-----------------------------------------
lbruun commented on issue #282: [NETBEANS-161] Changed license header
introducer to simple slash-star
URL:
https://github.com/apache/incubator-netbeans/pull/282#issuecomment-345551323
I don't think it is any safer to use include list. After all the snippet
only change those files which already today use `/**` as the beginning of the
license header. The match must be at the beginning of the file. It checks the
first 49 bytes of each file to see if there's a match.
If anything the method includes too _little_, not too _much_, as it doesn't
catch those Java files with CRLF which have inadvertently been committed to
Apache NetBeans during the past 2 months. Examples:
```text
autoupdate.services\test\unit\src\org\netbeans\modules\autoupdate\services\ExecutablePermissionsTestDisabled.java
autoupdate.services\test\unit\src\org\netbeans\modules\autoupdate\services\InstallEagerModuleTest.java
```
(ok, these aren't examples, these are actually the only ones I've found.
:-) )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Incorrect license header introducer
> -----------------------------------
>
> Key: NETBEANS-161
> URL: https://issues.apache.org/jira/browse/NETBEANS-161
> Project: NetBeans
> Issue Type: Bug
> Reporter: lbruun
> Assignee: lbruun
> Priority: Trivial
> Labels: pull-request-available
> Attachments: HeaderJavadocIntroducer.png
>
>
> The new Apache license header on {{.java}}, {{.cpp}}, etc files start with
> the Javadoc introducer (slash-star-star), rather than just the simple comment
> introducer (slash-star).
> This has some minor side-effects with e.g. source code formatting in the IDE.
> Here's a real-life example where this is really unhealthy:
> !HeaderJavadocIntroducer.png!
> Result in this case is that the license header becomes Javadoc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
