[
https://issues.apache.org/jira/browse/NETBEANS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265868#comment-16265868
]
ASF GitHub Bot commented on NETBEANS-161:
-----------------------------------------
lbruun commented on issue #293: [NETBEANS-161] edited some malformed/forgotten
license headers
URL:
https://github.com/apache/incubator-netbeans/pull/293#issuecomment-346970296
I think all changes in this PR looks good.
The reason why #282 didn't find these ones is because it deliberately erred
on the side of caution: it only considered files which started with `"**<LF> *
Licensed to ....`. For this reason it didn't find:
1. Files that uses Windows line endings (which is wrong, but that's another
story)
2. Files where there are some spaces before the license header actually
starts
3. Java files where the license header comes _after_ the package declaration
(also wrong)
This PR has found and fixes (2) and (3) as far as I can tell.
All good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Incorrect license header introducer
> -----------------------------------
>
> Key: NETBEANS-161
> URL: https://issues.apache.org/jira/browse/NETBEANS-161
> Project: NetBeans
> Issue Type: Bug
> Reporter: lbruun
> Assignee: lbruun
> Priority: Trivial
> Labels: pull-request-available
> Attachments: HeaderJavadocIntroducer.png
>
>
> The new Apache license header on {{.java}}, {{.cpp}}, etc files start with
> the Javadoc introducer (slash-star-star), rather than just the simple comment
> introducer (slash-star).
> This has some minor side-effects with e.g. source code formatting in the IDE.
> Here's a real-life example where this is really unhealthy:
> !HeaderJavadocIntroducer.png!
> Result in this case is that the license header becomes Javadoc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
