[
https://issues.apache.org/jira/browse/NETBEANS-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264105#comment-16264105
]
ASF GitHub Bot commented on NETBEANS-126:
-----------------------------------------
lbruun opened a new pull request #289: [NETBEANS-126] Replace with trademark
free icons
URL: https://github.com/apache/incubator-netbeans/pull/289
In an effort to move on with the ASF release, the icons which were
removed(*) from the donation are now replaced with icons which may not be the
prettiest but which are free from trademark or other restrictions. If the
outcome of [LEGAL-343](https://issues.apache.org/jira/browse/LEGAL-343) is that
the original icons are OK to be distributed as part of Apache NetBeans, then
this can be reversed, i.e. the original icons can be re-instated as per
[PR251](https://github.com/apache/incubator-netbeans/pull/251).
*) Technically they weren't removed but were replaced by Oracle with an NB
dummy icon
Changes are explained below.
### css.editor
The icons which hints the user about CSS support for various browsers looked
like this in NetBeans 8.2:
After this PR they'll look like this:
(icons are made by me, which is why they are so ugly, but they serve the
purpose for now)
### web.browser.api
All browser-logo icons are replaced by the generic browser icon (which was
already there in same location)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Browser icons needs to be re-instated
> -------------------------------------
>
> Key: NETBEANS-126
> URL: https://issues.apache.org/jira/browse/NETBEANS-126
> Project: NetBeans
> Issue Type: Bug
> Reporter: lbruun
> Assignee: lbruun
> Priority: Minor
> Labels: donation-fixes, pull-request-available
> Attachments: css-editor-icons-usage.png, css-editor-icons.png,
> nb-icon.png, web-browser-api-icons.png
>
>
> A number of browser icons were "removed" from the donation, in [this
> changeset|http://hg.netbeans.org/releases/rev/034a0c65c347?revcount=1500].
> They weren't actually removed, rather they were all replaced with a dummy
> NetBeans icon. I think Oracle removed them because Oracle couldn't donate
> such icons, as they don't "own" these trademarks.
> h2. Module path "css.editor"
> Removed from {{css.editor}}:
> !css-editor-icons.png!
> The browser icons in this module are - as far as I can tell - only used for
> code completion hints on CSS where they are used to signal if the browser has
> support for the CSS property or not. Example:
> !css-editor-icons-usage.png!
> h2. Module path "web.browser.api"
> Removed from {{web.browser.api}}:
> !web-browser-api-icons.png!
> The above icons are all replaced in the donation with a dummy NetBeans icon:
> !nb-icon.png!
> I'll do a PR to re-instate these.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
